{Network} Bump azure-mgmt-network from 19.3.0 to 20.0.0 #22487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
� Conflicts: � src/azure-cli/azure/cli/command_modules/acs/tests/latest/recordings/test_aks_control_plane_user_assigned_identity.yaml � src/azure-cli/azure/cli/command_modules/acs/tests/latest/recordings/test_aks_create_default_service_with_skip_role_assignment_msi.yaml � src/azure-cli/azure/cli/command_modules/acs/tests/latest/recordings/test_aks_create_node_public_ip.yaml � src/azure-cli/azure/cli/command_modules/acs/tests/latest/recordings/test_aks_create_slb_vmss_with_outbound_ip_prefixes_then_update_msi.yaml � src/azure-cli/azure/cli/command_modules/acs/tests/latest/recordings/test_aks_create_slb_vmss_with_outbound_ip_then_update_msi.yaml � src/azure-cli/azure/cli/command_modules/aro/tests/latest/recordings/test_aro_create.yaml � src/azure-cli/azure/cli/command_modules/aro/tests/latest/recordings/test_aro_delete.yaml � src/azure-cli/azure/cli/command_modules/aro/tests/latest/recordings/test_aro_list.yaml � src/azure-cli/azure/cli/command_modules/aro/tests/latest/recordings/test_aro_list_credentials.yaml � src/azure-cli/azure/cli/command_modules/aro/tests/latest/recordings/test_aro_show.yaml � src/azure-cli/azure/cli/command_modules/aro/tests/latest/recordings/test_aro_update.yaml � src/azure-cli/azure/cli/command_modules/eventhubs/tests/latest/recordings/test_eh_network.yaml � src/azure-cli/azure/cli/command_modules/eventhubs/tests/latest/recordings/test_eh_privateendpoint.yaml � src/azure-cli/azure/cli/command_modules/network/tests/latest/recordings/test_private_endpoint_connection_eventhub.yaml � src/azure-cli/requirements.py3.Darwin.txt � src/azure-cli/requirements.py3.Linux.txt � src/azure-cli/requirements.py3.windows.txt � src/azure-cli/setup.py
…twork-sdk � Conflicts: � src/azure-cli/azure/cli/command_modules/keyvault/tests/latest/recordings/test_keyvault_network_rule.yaml � src/azure-cli/azure/cli/command_modules/vm/tests/latest/recordings/test_image_builder_basic.yaml
ghost
requested review from
ghost
added
the
|
Network |
…twork-sdk � Conflicts: � src/azure-cli/azure/cli/command_modules/network/tests/latest/recordings/test_network_security_partner_provider.yaml � src/azure-cli/azure/cli/command_modules/network/tests/latest/recordings/test_private_endpoint_connection_service_bus.yaml � src/azure-cli/azure/cli/command_modules/servicebus/tests/latest/recordings/test_sb_network.yaml
necusjz
changed the title
…twork-sdk � Conflicts: � src/azure-cli/azure/cli/command_modules/backup/tests/latest/recordings/test_backup_restore.yaml
necusjz
requested review from
zhoxing-ms,
evelyn-ys,
calvinhzy,
jiasli,
DaeunYim,
digimaun,
panchagnula and
andyliuliming
as code owners
calvinhzy
approved these changes
May 18, 2022
jiasli
approved these changes
May 18, 2022
|
I saw https://pypi.org/project/azure-mgmt-network/20.0.0/#files https://pypi.org/project/azure-mgmt-network/19.3.0/#files This is a good sign for package size! |
jiasli
reviewed
May 18, 2022
| @@ -130,6 +130,7 @@ def path(self, args, kwargs): | |||
| raise CLIError('cloud name unexpectedly empty') | |||
| copy_kwargs = kwargs.copy() | |||
| copy_kwargs.pop('self', None) | |||
| copy_kwargs.pop('content_type', None) | |||
There was a problem hiding this comment.
Please leave a comment here describing why it is needed.
There was a problem hiding this comment.
This is for the signature change of Python SDK methods (Azure/azure-sdk-for-python#24162):
@distributed_trace
def begin_create_or_update(
self,
resource_group_name: str,
virtual_network_name: str,
parameters: "_models.VirtualNetwork",
*,
content_type: Optional[str] = "application/json",
**kwargs: Any
) -> LROPoller["_models.VirtualNetwork"]:To trigger it, run
az cloud set --profile 2018-03-01-hybrid --name AzureCloud
az network vnet update -n clitestvnet3 -g clitest.rgvsrrci2gv23pas67rbcxkq3wi3mlj5wohqb6capbzzu6mnlijgtvkrydqtmes4xth --set enableDdosProtection=true --defer
evelyn-ys
approved these changes
May 18, 2022
kairu-ms
approved these changes
May 18, 2022
wangzelin007
approved these changes
May 18, 2022
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
Bullet points:
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.